stubrunner. -> spring.cloud.contract.stubrunner. property migration #2309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcin Grzejszczak <[email protected]>
|
hi @marcingrzejszczak ; hope you're well! Elsewhere for property migrations we've seen deprecation entries added as seen here: {
"name": "logging.file.clean-history-on-start",
"type": "java.lang.Boolean",
"description": "Whether to clean the archive log files on startup. Only supported with the default logback setup.",
"sourceType": "org.springframework.boot.context.logging.LoggingApplicationListener",
"defaultValue": false,
"deprecation": {
"replacement": "logging.logback.rollingpolicy.clean-history-on-start",
"since": "2.4.0"
}
},Would it be possible to back fill those in https://github.com/spring-cloud/spring-cloud-contract/blob/v5.0.1/spring-cloud-contract-stub-runner/src/main/resources/META-INF/additional-spring-configuration-metadata.json ? That way Spring Tools users will get notified about the suggested replacements, as well as other tools using that metadata. 😇 |
Contributor
Author
|
That's a great idea. Sorry I haven't thought of that 🤦 |
marcingrzejszczak
added a commit
to marcingrzejszczak/spring-cloud-contract
that referenced
this pull request
Jan 6, 2026
Contributor
Author
|
There you go #2398 |
marcingrzejszczak
added a commit
to marcingrzejszczak/spring-cloud-contract
that referenced
this pull request
Jan 6, 2026
related to spring-cloudgh-2309 Signed-off-by: marcin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.